[
https://issues.apache.org/jira/browse/MWRAPPER-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509292#comment-17509292
]
ASF GitHub Bot commented on MWRAPPER-59:
----------------------------------------
slawekjaranowski commented on pull request #30:
URL: https://github.com/apache/maven-wrapper/pull/30#issuecomment-1073034101
You removed test `maven-wrapper-plugin/src/it/projects/type_source/`
How inline downloader are covered by tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inline MavenWrapperDownloader.java into mvnw
> --------------------------------------------
>
> Key: MWRAPPER-59
> URL: https://issues.apache.org/jira/browse/MWRAPPER-59
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Scripts
> Affects Versions: 3.1.0
> Reporter: James Z.M. Gao
> Priority: Major
>
> by inlining a lean version of MavenWrapperDownloader.java into `mnvw` script,
> we can remove the `source` installing type, and avoid reuse an outdated
> MavenWrapperDownloader.class
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
