slawekjaranowski commented on a change in pull request #25:
URL:
https://github.com/apache/maven-install-plugin/pull/25#discussion_r840302054
##########
File path: pom.xml
##########
@@ -185,27 +207,17 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-invoker-plugin</artifactId>
- <version>3.2.2</version>
<configuration>
-
<cloneProjectsTo>${project.build.directory}/it</cloneProjectsTo>
<cloneClean>true</cloneClean>
<pomIncludes>
<pomInclude>*/pom.xml</pomInclude>
<pomInclude>*/non-default-pom.xml</pomInclude>
</pomIncludes>
- <preBuildHookScript>setup</preBuildHookScript>
- <postBuildHookScript>verify</postBuildHookScript>
-
<localRepositoryPath>${project.build.directory}/local-repo</localRepositoryPath>
- <settingsFile>src/it/settings.xml</settingsFile>
<addTestClassPath>true</addTestClassPath>
<goals>
<goal>clean</goal>
<goal>install</goal>
</goals>
- <properties>
- <!-- e.g. ensure that Java7 picks up TLSv1.2 when connecting
with Central -->
- <https.protocols>${https.protocols}</https.protocols>
Review comment:
Identical configuration is in parent, so is not needed because is
inherited and of course is only needed when we want build by jdk 1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
