[ 
https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516344#comment-17516344
 ] 

Romain Manni-Bucau commented on MSHADE-417:
-------------------------------------------

[~hboutemy] , yes I don't have perms to do that (mentionned it a few times on 
slack, guess it is a bad username - romain.manni-bucau is the right one?).

Not sure about your use case for null bytes, do you have some sample? Max 
analyzis is right but also means we create a shade of nothing which sounds like 
a project setup error.

> Nul bytes appended to small files by maven-shade-plugin
> -------------------------------------------------------
>
>                 Key: MSHADE-417
>                 URL: https://issues.apache.org/jira/browse/MSHADE-417
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Max Zerzouri
>            Priority: Major
>         Attachments: original-shadetest-0.0.0.jar, pom.xml, 
> shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if 
> it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> 00000000: 61                                       a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> 00000000: 6100 0000                                a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in 
> the previous version, 3.2.4.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to