[GitHub] [maven-shade-plugin] rmannibucau commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

[GitBox]

rmannibucau commented on code in PR #129:
URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843877455


##########
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##########
@@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set<String> 
artifactsToRemove )
             origDeps = transitiveDeps;
         }
 
-        Model model = project.getOriginalModel();
+        final Model model = project.getFile() == null
+                            ? project.getOriginalModel().clone()
+                            : new MavenXpp3Reader().read( new FileInputStream( 
project.getFile() ) );

Review Comment:
   the inputstream will not be closed but the correct way to read a pom is 
org.apache.maven.model.io.ModelReader anyway



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org