Tibor17 commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r844229724
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -3114,9 +3114,12 @@ protected void warnIfIllegalFailOnFlakeCount() throws
MojoFailureException
private void printDefaultSeedIfNecessary()
{
- if ( getRunOrderRandomSeed() == null && getRunOrder().equals(
RunOrder.RANDOM.name() ) )
+ if ( getRunOrder().equals( RunOrder.RANDOM.name() ) )
{
- setRunOrderRandomSeed( System.nanoTime() );
+ if ( getRunOrderRandomSeed() == null )
+ {
+ setRunOrderRandomSeed( System.nanoTime() );
Review Comment:
Let's see the implementation, because the impl has much better opportunities
to use real random number if this parameter is NULL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
