[GitHub] [maven] slawekjaranowski commented on a diff in pull request #712: Use of the proposed new transformer API in Maven

[GitBox]

slawekjaranowski commented on code in PR #712:
URL: https://github.com/apache/maven/pull/712#discussion_r846606690


##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -261,9 +261,37 @@ else if ( request.isUpdateSnapshots() )
         mavenRepositorySystem.injectProxy( session, 
request.getPluginArtifactRepositories() );
         mavenRepositorySystem.injectAuthentication( session, 
request.getPluginArtifactRepositories() );
 
-        if ( Features.buildConsumer( request.getUserProperties() ).isActive() )
+        if ( !installRequestTransformers.isEmpty() )
+        {
+            if ( logger.isDebugEnabled() )
+            {
+                logger.debug( "Applying install request transformers (shown in 
order):" );
+                for ( InstallRequestTransformer transformer : 
installRequestTransformers )
+                {
+                    logger.debug( " * {}", transformer.getClass() );
+                }
+                logger.debug( "" );
+            }
+            session.getData().set(
+                    InstallRequestTransformer.KEY,
+                    new ChainedInstallRequestTransformer( 
installRequestTransformers )
+            );
+        }
+        if ( !deployRequestTransformers.isEmpty() )
         {
-            session.setFileTransformerManager( a -> 
getTransformersForArtifact( a, session.getData() ) );

Review Comment:
   do we remove both `setFileTransformerManager` and 
`getFileTransformerManager` from `session`?
   if not set what return get method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org