[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #505: [SUREFIRE-2055] Always show random seed

[GitBox]

slawekjaranowski commented on code in PR #505:
URL: https://github.com/apache/maven-surefire/pull/505#discussion_r846689054


##########
surefire-api/src/main/java/org/apache/maven/surefire/api/util/DefaultRunOrderCalculator.java:
##########
@@ -55,7 +55,7 @@ public DefaultRunOrderCalculator( RunOrderParameters 
runOrderParameters, int thr
         this.runOrder = runOrderParameters.getRunOrder();
         this.sortOrder = this.runOrder.length > 0 ? getSortOrderComparator( 
this.runOrder[0] ) : null;
         Long runOrderRandomSeed = runOrderParameters.getRunOrderRandomSeed();
-        this.random = new Random( runOrderRandomSeed == null ? 
System.nanoTime() : runOrderRandomSeed );
+        random = runOrderRandomSeed == null ? null : new Random( 
runOrderRandomSeed );

Review Comment:
   Why change in this way ...?
   When `rundom` will be null we will have NPE from `Collections.shuffle( 
testClasses, random );` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org