gnodet commented on code in PR #697:
URL: https://github.com/apache/maven/pull/697#discussion_r846991368


##########
maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/NodeBufferingParser.java:
##########
@@ -38,44 +37,54 @@
 
     private final List<Event> buffer = new ArrayList<>();
 
-    private final String nodeName;
+    private final ArrayList<String> stack = new ArrayList<>();

Review Comment:
   @cstamas I don't think this argument really holds in this case. The 
`NodeBufferingParser` also defines another abstract method which is defined by 
`void process( List<Event> buffer )`, so using a `List` instead of an 
`ArrayList` actually removes one import in all implementing classes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to