cstamas commented on code in PR #54:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/54#discussion_r858556675


##########
src/main/java/org/apache/maven/plugins/assembly/internal/ComponentSupport.java:
##########
@@ -19,16 +19,18 @@
  * under the License.
  */
 
-import org.codehaus.plexus.archiver.zip.ZipUnArchiver;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
- * @author jdcasey
- *
- *          //todo delete this class once the plexus maven plugin can merge a 
generated components.xml with an
- *          existing one.
+ * Support for components.
  */
-class SarUnArchiver
-    extends ZipUnArchiver
+public abstract class ComponentSupport

Review Comment:
   It is plugin internal anyway (look at pkg), is really just to lessen logger 
copy + pasta, but we can get rid of it, and just change all `getLogger()` 
occurences to `logger`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to