kwin commented on code in PR #86:
URL: https://github.com/apache/maven-release/pull/86#discussion_r867451954


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForDevelopmentPhase.java:
##########
@@ -65,7 +65,19 @@ protected void transformScm( MavenProject project, Model 
modelTarget, ReleaseDes
                         scmRoot.setConnection( scm.getConnection() );
                         scmRoot.setDeveloperConnection( 
scm.getDeveloperConnection() );
                         scmRoot.setUrl( scm.getUrl() );
-                        scmRoot.setTag( translator.resolveTag( scm.getTag() ) 
);
+                        String tag = translator.resolveTag( scm.getTag() );

Review Comment:
   @michael-o Ping. WDYT about my previous comment? Any chance to include this 
in the upcoming M6?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to