gnodet commented on code in PR #730: URL: https://github.com/apache/maven/pull/730#discussion_r870619812
########## maven-core/src/main/java/org/apache/maven/internal/MessageHelper.java: ########## @@ -0,0 +1,91 @@ +package org.apache.maven.internal; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.ArrayList; +import java.util.List; + +/** + * Helper class to format warning messages to the console + */ +public class MessageHelper +{ + + private static final int DEFAULT_MAX_SIZE = 65; Review Comment: Yes, that's in [MessageUtils from maven-shared-utils](https://github.com/apache/maven-shared-utils/blob/9f40037bfb04d54dd997a9ab837390045c9a4348/src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java#L225-L236). The reflow is already done dynamically, so that's not a problem. However, we go through the logging system, so the caller will have to hard code somehow the size needed for the `[WARN] ` prefix (or whatever can be configured), as I don't think we can compute it easily. I'll can give it a try at adding a parameter for the max length and have the caller use it with the terminal width (and a maximum, as a one line message might be hard to read... or not ? ). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
