Jorge Solórzano created MWRAPPER-65:
---------------------------------------

             Summary: MavenWrapperDownloader.java ignores the MVNW_REPOURL env
                 Key: MWRAPPER-65
                 URL: https://issues.apache.org/jira/browse/MWRAPPER-65
             Project: Maven Wrapper
          Issue Type: Bug
          Components: Maven Wrapper Scripts
    Affects Versions: 3.1.0, 3.1.1
            Reporter: Jorge Solórzano


Problem:
MavenWrapperDownloader.java does not read the environment variable 
MVNW_REPOURL, so in the case the script has to fallback to the java download 
version instead of wget/curl, then the behavior will be different.

Proposal:
Instead of making MavenWrapperDownloader.java more complex I actually propose 
the opposite, the MavenWrapperDownloader.java can be simplified by removing 
code that's already done by the script such as the reading of the property 
file, the DEFAULT_DOWNLOAD_URL... basically make the 
MavenWrapperDownloader.java to behave as curl and wget by passing 
"$wrapperJarPath" "$wrapperUrl" parameters without a lot of the current logic 
that's already done on the script.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to