AlexanderAshitkin commented on code in PR #14:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/14#discussion_r874814667


##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -166,22 +166,22 @@ public CacheResult findCachedBuild( MavenSession session, 
MavenProject project,
         ProjectsInputInfo inputInfo = projectInputCalculator.calculateInput( 
project );
 
         final CacheContext context = new CacheContext( project, inputInfo, 
session );
-        // remote build first
-        CacheResult result = findCachedBuild( mojoExecutions, context );

Review Comment:
   @gnodet  @maximilian-novikov-db remote honestly this change brings 
regression.
   There are 2 local caches: 
   1) local cache of remote repository
   2) cache of local builds
   
   Previously, if remote build was present in local cache it was always used - 
there was no lookup. Now local build used with priority which could lead to 
difficult to debug issues.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to