[
https://issues.apache.org/jira/browse/MBUILDCACHE-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538191#comment-17538191
]
ASF GitHub Bot commented on MBUILDCACHE-20:
-------------------------------------------
AlexanderAshitkin commented on code in PR #14:
URL:
https://github.com/apache/maven-build-cache-extension/pull/14#discussion_r874814667
##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -166,22 +166,22 @@ public CacheResult findCachedBuild( MavenSession session,
MavenProject project,
ProjectsInputInfo inputInfo = projectInputCalculator.calculateInput(
project );
final CacheContext context = new CacheContext( project, inputInfo,
session );
- // remote build first
- CacheResult result = findCachedBuild( mojoExecutions, context );
Review Comment:
@gnodet @maximilian-novikov-db remote honestly this change brings
regression.
There are 2 local caches:
1) local cache of remote repository
2) cache of local builds
Previously, if remote build was present in local cache it was always used -
there was no lookup. Now local build used with priority which could lead to
difficult to debug issues. And performance benefits are minimal
> Allow configuring whether local or remote builds should be preferred
> --------------------------------------------------------------------
>
> Key: MBUILDCACHE-20
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-20
> Project: Maven Build Cache Extension
> Issue Type: Improvement
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0.0-alpha
>
>
> Currently, a remote lookup is done first and if none succeeds, a lookup of a
> previous local build is done (for a given input checksum). I don't really
> understand the benefit of this and I think it should be reversed, or at least
> made configurable.
> The code is at:
> https://github.com/apache/maven-build-cache-extension/blob/a3a44e72404228c536b5a8c21d2e67f0183452a1/src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java#L169-L187
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
