[
https://issues.apache.org/jira/browse/MWRAPPER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538204#comment-17538204
]
ASF GitHub Bot commented on MWRAPPER-66:
----------------------------------------
jorsol opened a new pull request, #43:
URL: https://github.com/apache/maven-wrapper/pull/43
While using `https` is valid per
https://issues.apache.org/jira/browse/LEGAL-265, this just make RAT plugin
happy (since the fix isn't released yet).
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> maven-wrapper.properties - incorrect header reported by rat plugin
> -------------------------------------------------------------------
>
> Key: MWRAPPER-66
> URL: https://issues.apache.org/jira/browse/MWRAPPER-66
> Project: Maven Wrapper
> Issue Type: Bug
> Affects Versions: 3.1.1
> Reporter: Slawomir Jaranowski
> Priority: Critical
>
> In maven-wrapper.properties we have
> {code}
> # https://www.apache.org/licenses/LICENSE-2.0
> {code}
> instead
> {code}
> # http://www.apache.org/licenses/LICENSE-2.0
> {code}
> standard configuration of {{apache-rat-plugin}} used in Maven project report
> issues on it.
> reproduce - go to maven-parent project
> {code}
> mvn wrapper:wrapper
> mvn verify
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
