[
https://issues.apache.org/jira/browse/MNG-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539554#comment-17539554
]
ASF GitHub Bot commented on MNG-7401:
-------------------------------------
laeubi commented on PR #743:
URL: https://github.com/apache/maven/pull/743#issuecomment-1131687007
> We should maybe also deprecate this method and suggest that plugins should
have the project injected in a field
I think the problem is that we then need some kind of "ProjectScope", I
think `MavenSession.set/getCurrentProject()` should simply become a
ThreadLocal, we document that and if one needs to pass data to a different
thread he first need to fetch the current project.
> Make MavenSession#getCurrentProject() using a thread local
> ----------------------------------------------------------
>
> Key: MNG-7401
> URL: https://issues.apache.org/jira/browse/MNG-7401
> Project: Maven
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
> Fix For: waiting-for-feedback
>
>
> I noticed that a session is often cloned due to change the current project
> for a while.
> As this works for everyone passing down the session, consumers of the "upper
> session" (e.g. a SessionScoped Component) would never see this if they are
> (indirectly) called and e.g. use Session#getCurrentProject().
> I wonder if MavenSession could simply use a ThreadLocal for the
> currentProject (that is shared accross all cloned sessions), that way one
> would always get the correct value.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
