mthmulders commented on code in PR #126:
URL:
https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r877784583
##########
.github/workflows/maven-verify.yml:
##########
@@ -27,4 +27,5 @@ jobs:
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
with:
jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica",
"adopt-openj9" ]'
Review Comment:
Usually, I'd say "a Hotspot VM and an OpenJ9 VM". For OpenJ9, we don't have
my choices; for Hotspot, I guess Temurin or maybe Zulu?
But if you're saying there are differences (e.g. in generated Javadoc) and
they matter for the m-c-p, then we should include them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
