[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541961#comment-17541961
]
ASF GitHub Bot commented on SCM-977:
------------------------------------
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881493091
##########
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##########
@@ -466,6 +518,11 @@ public String toString()
{
StringBuilder result = new StringBuilder( author == null ? " null " :
author );
result.append( "\n" ).append( date == null ? "null " : date.toString()
).append( "\n" );
+ List<String> tags = getTags();
+ if ( tags != null && !tags.isEmpty() )
Review Comment:
The null check is redudant, see your new code.
##########
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##########
@@ -552,6 +609,16 @@ public String toXML()
buffer.append( "\t\t<msg><![CDATA[" )
.append( removeCDataEnd( comment ) )
.append( "]]></msg>\n" );
+ List<String> tags = getTags();
+ if ( tags != null && !tags.isEmpty() )
Review Comment:
The null check is redudant, see your new code.
> Retrieve the tags on commits using the changelog command.
> ---------------------------------------------------------
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
> Reporter: Niels Basjes
> Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
