[
https://issues.apache.org/jira/browse/MWRAPPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554527#comment-17554527
]
ASF GitHub Bot commented on MWRAPPER-68:
----------------------------------------
luschmar opened a new pull request, #51:
URL: https://github.com/apache/maven-wrapper/pull/51
Following this checklist to help us incorporate your
contribution quickly and easily:
- [/] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [/] Each commit in the pull request should have a meaningful subject line
and body.
- [/] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [/] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [/] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [/] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [/] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> MVNW_REPOURL improperly formed distributionUrl
> ----------------------------------------------
>
> Key: MWRAPPER-68
> URL: https://issues.apache.org/jira/browse/MWRAPPER-68
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Jar
> Affects Versions: 3.1.1
> Reporter: HumanFund
> Priority: Major
>
> In Maven Wrapper v3.1.1, Installer::createDist(), file
> maven-wrapper/src/main/java/org/apache/maven/wrapper/Installer.java, was
> updated on line 74 to be:
> distributionUrl = new URI( mvnwRepoUrl ).resolve( "/" ).resolve( mvnPath );
> The above update is causing the distributionUrl to be improperly formed based
> on the MVNW_REPOURL environment variable and the mvnPath which is extracted
> from the distributionUrl in maven-wrapper.properties, specifically the
> substring starting with "org/apache/maven".
> The update was introduced in the following commit:
> [https://github.com/apache/maven-wrapper/commit/22a3268def96e5e648aa97a49d9e146e529b7c87#diff-193f3775e6efb0b6ed01219b21272f9eb3861965ce3af3586a0ce8eb153359c0]
> An example of the results are shown below. Note the "Downloading" URI does
> not include the entire repo url, only the scheme, host, and port, then the
> maven path is appended.
> The repo url is getting truncated by the call to resolve( "/" ) on line 74.
> I do not currently see a purpose for having this call in place. I made the
> following update to line 74 and it works fine:
> distributionUrl = new URI( mvnwRepoUrl ).resolve( mvnPath );
> Note that in Maven Wrapper v3.1.0, the distributionUrl was formed simply by
> appending the maven path to the MVNW_REPOURL:
> distributionUrl = new URI( mvnwRepoUrl + "/" + mvnPath );
> Example output demonstrating issue:
> [exec] [INFO] Apache Maven Wrapper 3.1.1
> [exec] [INFO] Detected MVNW_REPOURL environment variable
> [http://localhost:8081/repository/repo-maven-apache-org-maven2/]
> [exec] [INFO] Installing Maven distribution
> /home/myexamplehome/maven/wrapper/dists/apache-maven-3.6.3-bin/cf3cf814
> [exec] [INFO] Downloading
> [http://localhost:8081/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip]
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
