michael-o commented on code in PR #15:
URL:
https://github.com/apache/maven-install-plugin/pull/15#discussion_r909604461
##########
src/main/java/org/apache/maven/plugins/install/InstallMojo.java:
##########
@@ -83,24 +83,30 @@
@Component
private ProjectInstaller installer;
+ private enum State
+ {
+ SKIPPED, INSTALLED, TO_BE_INSTALLED
+ }
+
public void execute()
throws MojoExecutionException, MojoFailureException
{
if ( skip )
{
- getPluginContext().put( INSTALL_PROCESSED_MARKER, Boolean.FALSE );
getLog().info( "Skipping artifact installation" );
+ getPluginContext().put( INSTALL_PROCESSED_MARKER,
State.SKIPPED.name() );
Review Comment:
If we have objects, why not retain the enum, why use name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
