Giovds commented on code in PR #701:
URL: https://github.com/apache/maven/pull/701#discussion_r910382076
##########
maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##########
@@ -132,6 +137,7 @@ public DefaultMaven(
this.buildResumptionAnalyzer = buildResumptionAnalyzer;
this.buildResumptionDataRepository = buildResumptionDataRepository;
this.superPomProvider = superPomProvider;
+ this.projectSelector = new ProjectSelector();
Review Comment:
The reasoning behind this is that the `ProjectSelector` is likely only going
to be used in two classes (`DefaultMaven` and `DefaultGraphBuilder`) and does
not require any complex configuration to be created. It's relatively
lightweight and I would have liked to make it package-private as well but since
`DefaultMaven` is in a different package this wasn't possible. If it preferred
to subject it to DI I'll happily change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
