cstamas commented on code in PR #32:
URL:
https://github.com/apache/maven-install-plugin/pull/32#discussion_r917692432
##########
src/main/java/org/apache/maven/plugins/install/InstallMojo.java:
##########
@@ -153,31 +163,90 @@ private boolean allProjectsMarked()
return true;
}
- private void installProject( MavenProject pir )
- throws MojoFailureException, MojoExecutionException
+ private void installProject( MavenProject project ) throws
MojoExecutionException, MojoFailureException
{
try
{
- installer.install( session.getProjectBuildingRequest(), new
ProjectInstallerRequest().setProject( pir ) );
+ repositorySystem.install( session.getRepositorySession(),
processProject( project ) );
}
- catch ( IOException e )
+ catch ( IllegalArgumentException e )
{
- throw new MojoFailureException( "IOException", e );
+ throw new MojoFailureException( e.getMessage(), e );
Review Comment:
Hm, we need to clean up this I guess.... (as now I see that I used the two
inconsistently).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
