[
https://issues.apache.org/jira/browse/MINSTALL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamás Cservenák updated MINSTALL-177:
-------------------------------------
Description:
Original plugin made hoops and loops, instead to perform what it needed to
perform. Partly to blame this was unfinished state of MAT API (it was able to
install project only).
Installing project is needed in InstallMojo, but InstallFileMojo was forced to
make hoops and loops due this, as it was passed one file (and maybe pomFile),
and it was forced to create "fake" project, decorate and fake setup it with all
whistle and bells, only to get it via MAT to resolver that would "decompose" it
back into set of artifacts needing a deploy. So it went this
file-artifact-project-artifact route, that made all the logic fragile and
overly complicated.
This PR completely reworks m-install-p making it (almost trivially) simple: it
does what it needs to do, without any fuss, and does it in streamlined way:
InstallMojo will create a list of artifacts out of project and pass it to
repository system for deploy, while InstallFileMojo literally prepares just a
deployment request, nothing more. No fuss, no magic, no fake project building
etc.
was:
The plugin used MAT for historical reasons (when covering 3.0-3.1+ was needed).
Also, due state of MAT API (unfinished), the Mojo (esp InstallFile) was doomed
to perform way more cruft than needed (had to create "fake" project, decorate
it, etc).
Simply drop the MAT and go directly for resolver (as we are 3.2.5+ now).
> Cleanup the plugin
> ------------------
>
> Key: MINSTALL-177
> URL: https://issues.apache.org/jira/browse/MINSTALL-177
> Project: Maven Install Plugin
> Issue Type: Task
> Reporter: Tamás Cservenák
> Priority: Major
> Fix For: 3.0.0
>
>
> Original plugin made hoops and loops, instead to perform what it needed to
> perform. Partly to blame this was unfinished state of MAT API (it was able to
> install project only).
> Installing project is needed in InstallMojo, but InstallFileMojo was forced
> to make hoops and loops due this, as it was passed one file (and maybe
> pomFile), and it was forced to create "fake" project, decorate and fake setup
> it with all whistle and bells, only to get it via MAT to resolver that would
> "decompose" it back into set of artifacts needing a deploy. So it went this
> file-artifact-project-artifact route, that made all the logic fragile and
> overly complicated.
> This PR completely reworks m-install-p making it (almost trivially) simple:
> it does what it needs to do, without any fuss, and does it in streamlined
> way: InstallMojo will create a list of artifacts out of project and pass it
> to repository system for deploy, while InstallFileMojo literally prepares
> just a deployment request, nothing more. No fuss, no magic, no fake project
> building etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
