[ https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568574#comment-17568574 ]
ASF GitHub Bot commented on SCM-945: ------------------------------------ kwin commented on code in PR #153: URL: https://github.com/apache/maven-scm/pull/153#discussion_r924525383 ########## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/JGitTransportConfigCallback.java: ########## @@ -19,47 +19,22 @@ * under the License. */ -import com.jcraft.jsch.JSch; -import com.jcraft.jsch.JSchException; -import com.jcraft.jsch.Session; -import org.apache.maven.scm.provider.git.repository.GitScmProviderRepository; import org.eclipse.jgit.api.TransportConfigCallback; -import org.eclipse.jgit.transport.JschConfigSessionFactory; -import org.eclipse.jgit.transport.OpenSshConfig; -import org.eclipse.jgit.transport.SshSessionFactory; import org.eclipse.jgit.transport.SshTransport; import org.eclipse.jgit.transport.Transport; -import org.eclipse.jgit.util.FS; -import org.eclipse.jgit.util.StringUtils; -import org.slf4j.Logger; +import org.eclipse.jgit.transport.sshd.SshdSessionFactory; /** * Implementation of {@link TransportConfigCallback} which adds * a public/private key identity to ssh URLs if configured. */ public class JGitTransportConfigCallback implements TransportConfigCallback { - private SshSessionFactory sshSessionFactory = null; + private final SshdSessionFactory sshSessionFactory; Review Comment: same as above, I would keep the simple name for the variable. The more complicated class name is given by the Mina library. > Support OpenSSH private keys with maven-scm-provider-jgit > --------------------------------------------------------- > > Key: SCM-945 > URL: https://issues.apache.org/jira/browse/SCM-945 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-jgit > Affects Versions: 1.11.2 > Reporter: Konrad Windszus > Assignee: Michael Osipov > Priority: Major > > For SSH based authentication with private keys in the OpenSSH format the > following error is being emitted: {{invalid privatekey: ...}} > This is due to the use of JGit 4.5.4 > (https://github.com/apache/maven-scm/blob/c5eb2c187568809e0dc0ea9ac83031f1dcb5ad1a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml#L53) > which used JSch which lacks support for those private keys. JGit 5.2 comes > with a new SSH implementation > (https://bugs.eclipse.org/bugs/show_bug.cgi?id=520927) and should by that > also support OpenSSH private keys. -- This message was sent by Atlassian Jira (v8.20.10#820010)