[
https://issues.apache.org/jira/browse/SCM-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568681#comment-17568681
]
ASF GitHub Bot commented on SCM-994:
------------------------------------
kwin commented on code in PR #154:
URL: https://github.com/apache/maven-scm/pull/154#discussion_r924852998
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java:
##########
@@ -54,6 +58,21 @@
public class JGitScmProvider
extends AbstractGitScmProvider
{
+ private final PlexusInteractivityCredentialsProvider credentialsProvider;
+
+ @Inject
+ public JGitScmProvider( Prompter prompter )
+ {
+ credentialsProvider = new PlexusInteractivityCredentialsProvider(
prompter );
+ CredentialsProvider.setDefault( credentialsProvider );
Review Comment:
yes. I think clashes are very unlikely, isn’t it?
> Add JGit CredentialsProvider based on Plexus Interactivity API
> --------------------------------------------------------------
>
> Key: SCM-994
> URL: https://issues.apache.org/jira/browse/SCM-994
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-scm-provider-jgit
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently the JGit provider does not provide interactive communication means,
> e.g. for asking for a password or adding a new server to the known hosts.
> There should be an implementation for
> https://javadoc.io/static/org.eclipse.jgit/org.eclipse.jgit/5.13.1.202206130422-r/org/eclipse/jgit/transport/CredentialsProvider.html
> backed by Plexus's Prompter component
> (https://codehaus-plexus.github.io/plexus-interactivity/plexus-interactivity-api/apidocs/org/codehaus/plexus/components/interactivity/Prompter.html).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
