michael-o commented on code in PR #154:
URL: https://github.com/apache/maven-scm/pull/154#discussion_r924854870
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java:
##########
@@ -54,6 +58,21 @@
public class JGitScmProvider
extends AbstractGitScmProvider
{
+ private final PlexusInteractivityCredentialsProvider credentialsProvider;
+
+ @Inject
+ public JGitScmProvider( Prompter prompter )
+ {
+ credentialsProvider = new PlexusInteractivityCredentialsProvider(
prompter );
+ CredentialsProvider.setDefault( credentialsProvider );
Review Comment:
As long as we can assure that everything is a singleton and we don't have
any race conditions. Setters like this expect all to be configured *before*
workers are spawned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
