[
https://issues.apache.org/jira/browse/MNG-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572654#comment-17572654
]
ASF GitHub Bot commented on MNG-7443:
-------------------------------------
Giovds commented on code in PR #701:
URL: https://github.com/apache/maven/pull/701#discussion_r932658689
##########
maven-core/src/main/java/org/apache/maven/graph/ProjectSelector.java:
##########
@@ -0,0 +1,160 @@
+package org.apache.maven.graph;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.MavenExecutionException;
+import org.apache.maven.execution.MavenExecutionRequest;
+import org.apache.maven.project.MavenProject;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+
+/**
+ * Utility class to extract {@link MavenProject} from the project graph during
the execution phase based on optional or
+ * required selectors.
+ */
+public final class ProjectSelector
+{
+ private static final Logger LOGGER = LoggerFactory.getLogger(
ProjectSelector.class );
+
+ public Set<MavenProject> getRequiredProjectsBySelectors(
MavenExecutionRequest request, List<MavenProject> projects,
+ Set<String>
projectSelectors )
+ throws MavenExecutionException
+ {
+ Set<MavenProject> selectedProjects = new LinkedHashSet<>();
+ File baseDirectory = getBaseDirectoryFromRequest( request );
+ for ( String selector : projectSelectors )
+ {
+ Optional<MavenProject> optSelectedProject =
+ findOptionalProjectBySelector( projects, baseDirectory,
selector );
+ if ( !optSelectedProject.isPresent() )
+ {
+ String message = "Could not find the selected project in the
reactor: " + selector;
+ throw new MavenExecutionException( message, request.getPom() );
+ }
+
+ MavenProject selectedProject = optSelectedProject.get();
+
+ selectedProjects.add( selectedProject );
+ selectedProjects.addAll( getChildProjects( selectedProject,
request ) );
+ }
+
+ return selectedProjects;
+ }
+
+ public Set<MavenProject> getOptionalProjectsBySelectors(
MavenExecutionRequest request, List<MavenProject> projects,
+ Set<String>
projectSelectors )
+ {
+ Set<MavenProject> resolvedOptionalProjects = new LinkedHashSet<>();
+ Set<String> unresolvedOptionalSelectors = new HashSet<>();
+ File baseDirectory = getBaseDirectoryFromRequest( request );
+ for ( String selector : projectSelectors )
+ {
+ Optional<MavenProject> optSelectedProject =
+ findOptionalProjectBySelector( projects, baseDirectory,
selector );
+ if ( optSelectedProject.isPresent() )
+ {
+ resolvedOptionalProjects.add( optSelectedProject.get() );
+ resolvedOptionalProjects.addAll( getChildProjects(
optSelectedProject.get(), request ) );
+ }
+ else
+ {
+ unresolvedOptionalSelectors.add( selector );
+ }
+ }
+
+ if ( !unresolvedOptionalSelectors.isEmpty() )
+ {
+ String message = String.format( "The requested optional projects
[%s] do not exist.",
+ String.join( ",", unresolvedOptionalSelectors ) );
+ LOGGER.info( message );
Review Comment:
Tested it locally and it worked to use the string representation of the
collection w/ SLF4J.
This does result in `[:proj1,:proj2]` - which the PR does already anyway.
I'd suggesting replacing the
[other](https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/DefaultMaven.java#L626)
[occurrences](https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/DefaultMaven.java#L654)
as well in `DefaultMaven` to keep it consistent. Or change the current
implementation to `String.join(", ", unresolvedOptionalSelectors)`. Either is
fine for me.
> Consistent logging between optional projects and optional profiles
> ------------------------------------------------------------------
>
> Key: MNG-7443
> URL: https://issues.apache.org/jira/browse/MNG-7443
> Project: Maven
> Issue Type: Improvement
> Components: Core, Logging
> Affects Versions: 4.0.0-alpha-1
> Reporter: Giovanni van der Schelde
> Priority: Minor
> Attachments: example.png
>
>
> Maven 4 introduces optional profiles and optional projects. However, the
> feedback provided to the user on whether a project or profile has been
> skipped is inconsistent between the two (see image attached).
> For profiles, it will be logged twice: before and after the build.
> For projects, it will be logged once: before the build.
> The idea would be to log the information for skipped optional projects after
> the build as well.
> !example.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
