[
https://issues.apache.org/jira/browse/DOXIA-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576019#comment-17576019
]
ASF GitHub Bot commented on DOXIA-670:
--------------------------------------
michael-o commented on code in PR #116:
URL: https://github.com/apache/maven-doxia/pull/116#discussion_r939155456
##########
doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocSink.java:
##########
@@ -382,119 +377,6 @@ else if ( depth == SECTION_LEVEL_5 )
//
// -----------------------------------------------------------------------
- /**
- * {@inheritDoc}
- *
- * @see XdocMarkup#SOURCE_TAG
- * @see javax.swing.text.html.HTML.Tag#PRE
- * @param attributes a {@link
org.apache.maven.doxia.sink.SinkEventAttributes} object.
- */
- public void verbatim( SinkEventAttributes attributes )
- {
Review Comment:
I think this statement is nonsense and this method needs to be retained:
* Xdoc uses element of HTML5, but is not HTML5
* When XdocParser writes to a sink that sink will never see `<source>`
anymore.
We have here a mix of custom elements and HTML5.
> Remove code duplication in XdocSink
> -----------------------------------
>
> Key: DOXIA-670
> URL: https://issues.apache.org/jira/browse/DOXIA-670
> Project: Maven Doxia
> Issue Type: Task
> Components: Module - Xhtml
> Affects Versions: 2.0.0-M3
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0-M4
>
>
> {{XdocSink}} duplicates code from the parent class. That code can be removed.
> It has one caveat: The {{source}} element cannot be retained at all because
> it has a completely different meaning in HTML5:
> https://www.tutorialrepublic.com/html-reference/html5-source-tag.php and
> since only the {{XHTML5Parser}} can properly detect the new construct
> {{verbatim(boxed)}} will always be parsed as unboxed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
