michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964098369
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -1237,20 +1237,9 @@ public void executeGoals( List<String> goals,
Map<String, String> envVars )
File logFile = new File( getBasedir(), getLogFileName() );
- for ( Object cliOption : cliOptions )
+ for ( String cliOption : cliOptions )
{
- String key = String.valueOf( cliOption );
-
- String resolvedArg = resolveCommandLineArg( key );
-
- try
- {
- args.addAll( Arrays.asList(
CommandLineUtils.translateCommandline( resolvedArg ) ) );
- }
- catch ( Exception e )
- {
- e.printStackTrace();
- }
+ args.add( resolveCommandLineArg( cliOption ) );
Review Comment:
Honestly, I don't understand the purpose of this at all:
https://github.com/apache/maven-verifier/blob/96c30e3cea783fcbb06963f98754a32148957f1b/src/main/java/org/apache/maven/shared/verifier/Verifier.java#L1418-L1422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
