michael-o commented on code in PR #43:
URL: https://github.com/apache/maven-verifier/pull/43#discussion_r967866316
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -1284,8 +1335,6 @@ public void executeGoals( List<String> goals, Map<String,
String> envVars )
if ( ret > 0 )
{
- System.err.println( "Exit code: " + ret );
Review Comment:
Very good!
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -1263,12 +1301,25 @@ public void executeGoals( List<String> goals,
Map<String, String> envVars )
args.add( "-Dmaven.repo.local=" + localRepo );
}
- args.addAll( allGoals );
+ if ( autoclean )
+ {
+ /*
+ * NOTE: Neither test lifecycle binding nor prefix resolution here
but call the goal directly.
+ */
+ args.add( "org.apache.maven.plugins:maven-clean-plugin:clean" );
Review Comment:
Would it make sense to move this value to a static final for documentation
puposes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
