[ https://issues.apache.org/jira/browse/MNG-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603916#comment-17603916 ]
ASF GitHub Bot commented on MNG-7098: ------------------------------------- Giovds commented on code in PR #783: URL: https://github.com/apache/maven/pull/783#discussion_r970407944 ########## maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java: ########## @@ -143,7 +143,11 @@ public void sessionStarted( ExecutionEvent event ) project.getName(), chars( ' ', ( len > 0 ) ? len : 1 ), project.getPackaging() ); } - totalProjects = projects.size(); + final List<MavenProject> allProjects = event.getSession().getAllProjects(); Review Comment: It makes sense to me to keep using this method. Perhaps the comment could be removed to avoid confusion as it is not annotated with `@Deprecated` and it is used in multiple places. I agree that these kind of "deprecation messages" are quite useless indeed. > Project counter should be cumulative when using resume > ------------------------------------------------------ > > Key: MNG-7098 > URL: https://issues.apache.org/jira/browse/MNG-7098 > Project: Maven > Issue Type: Improvement > Components: Reactor and Workspace > Reporter: Robert Scholte > Priority: Minor > Fix For: 4.0.x-candidate > > > When doing a resume on a build, the counter now starts again at 1. > E.g. Suppose a project has 10 modules and the 7th module fails. With a resume > now you'll see {{[1/4]}}. > To me it makes more sense to say {{[7/10]}}. You're still as close to the end > as usual, but this indicates the size of the complete project. -- This message was sent by Atlassian Jira (v8.20.10#820010)