[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #24: [MBUILDCACHE-22] added possibility to skip cache lookup per project or globally

[GitBox]

AlexanderAshitkin commented on code in PR #24:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/24#discussion_r970826571


##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -180,9 +182,21 @@ public MavenProjectInput( MavenProject project,
         {
             if ( propertyName.startsWith( CACHE_EXCLUDE_NAME ) )
             {
+                String propertyValue = properties.getProperty( propertyName );
+                Path path = Paths.get( propertyValue );
+                filteredOutPaths.add( path );
+                if ( LOGGER.isDebugEnabled() )
+                {
+                    LOGGER.debug( "Adding an excludePath from property '{}', 
values is '{}', path is '{}' ",
+                            propertyName, propertyValue, path );
+                }
+
                 filteredOutPaths.add( Paths.get( properties.getProperty( 
propertyName ) ) );
             }
         }
+        CacheUtils.debugPrintCollection( LOGGER, filteredOutPaths,
+                "List of excluded paths (checked either by fileName or by 
startsWith prefix)",
+                "Pah entry" );

Review Comment:
   typo. `Pah entry` is a medical term likely ¯\_(ツ)_/¯



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org