gnodet commented on code in PR #199:
URL:
https://github.com/apache/maven-integration-testing/pull/199#discussion_r971987215
##########
core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java:
##########
@@ -568,33 +568,19 @@ protected Verifier newVerifier( String basedir, String
settings, boolean debug )
String path = settingsFile.getAbsolutePath();
- // dedicated CLI option only available since MNG-3914
- if ( matchesVersionRange( "[2.1.0,)" ) )
+ verifier.addCliOption( "--global-settings" );
+ if ( path.indexOf( ' ' ) < 0 )
{
- verifier.addCliOption( "--global-settings" );
- if ( path.indexOf( ' ' ) < 0 )
- {
- verifier.addCliOption( path );
- }
- else
- {
- verifier.addCliOption( '"' + path + '"' );
- }
+ verifier.addCliOption( path );
}
else
{
- verifier.getSystemProperties().put(
"org.apache.maven.global-settings", path );
+ verifier.addCliOption( '"' + path + '"' );
}
Review Comment:
Yes, note that the upgrade to verifier 2.0 will break quotes arguments.
Also note that I plan to merge
https://github.com/apache/maven-integration-testing/pull/176 soon and it
includes an upgrade to verifier 2.0-SNAPSHOT. Unless we really do want to
postpone until it's released, but the snapshots are available on public apache
repos, so that's not a dealbreaker, especially as ITs are never released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
