gnodet commented on code in PR #49:
URL: https://github.com/apache/maven-verifier/pull/49#discussion_r976598947
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -1205,8 +1207,6 @@ public String getExecutable()
* verifier.setEnvironmentVariable( "key2", "value2" );
* verifier.execute();
* </pre>
- *
- * @deprecated will be removed without replacement.
*/
public void executeGoals( List<String> goals, Map<String, String> envVars )
Review Comment:
Missing `@Deprecated` annotation.
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -1165,14 +1165,14 @@ public void executeGoal( String goal, Map<String,
String> envVars )
/**
* Execute Maven.
+ *
+ * @deprecated will be removed
* <p>
* For replacement please use:
* <pre>
* verifier.addCliArguments( "goal1", "goal2" );
* verifier.execute();
* </pre>
- *
- * @deprecated will be removed without replacement.
*/
public void executeGoals( List<String> goals )
Review Comment:
Missing `@Deprecated` annotation.
##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -1154,8 +1156,6 @@ public void executeGoal( String goal )
* verifier.setEnvironmentVariable( "key2", "value2" );
* verifier.execute();
* </pre>
- *
- * @deprecated will be removed without replacement.
*/
public void executeGoal( String goal, Map<String, String> envVars )
Review Comment:
I think it's missing a `@Deprecated` annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]