cstamas commented on code in PR #200:
URL: https://github.com/apache/maven-resolver/pull/200#discussion_r991616229
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:
##########
@@ -410,6 +425,11 @@ else if ( local.getFile() != null )
performDownloads( session, group );
}
+ for ( ArtifactResolverPostProcessor artifactResolverPostProcessor :
artifactResolverPostProcessors.values() )
+ {
+ artifactResolverPostProcessor.postProcess( session, results );
Review Comment:
The outcome is not needed at all, as post processor communicate with
resolver via `results` (just like before), and as I wrote several rounds
before, decided to move PP invocation before final "processing" of resolver,
where failures (basically, unresolved artifacts) are detected. Hence, if PP
wants to fail resolution, all it should do (and was doing before) is to
"decorate" result with exception, and make artifact unresolved, and from this
moment on, there is really no need for any "outcome", as all the information is
passed via results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
