kwin commented on PR #827:
URL: https://github.com/apache/maven/pull/827#issuecomment-1277966331

   @slawekjaranowski Thanks for the proposal, sounds good, but I am not sure 
when to call the validator. From both places where 
`MavenPluginManager#checkRequiredMavenVersion` is currently called? That may 
IMHO be too often and it seems that the 
`DefaultPluginVersionResolver#isCompatible(...)` is just silently ignoring 
incompatible versions. Also version incompatibility for me is semantically 
different from an invalid plugin descriptor. Therefore I am not sure about the 
naming `PluginDescriptorValidator`. The other validators primarily check for 
valid XML, which is different from compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to