gzm55 commented on PR #712: URL: https://github.com/apache/maven-mvnd/pull/712#issuecomment-1279968457
> > > Is there any good reason to keep both an option and a property ? I think they should be merged together. > > > > > > if merged, with type `OptionType.VOID`, the [`getCommandLineOption`](https://github.com/apache/maven-mvnd/blob/5e59c404535ba21b925a372340c7b11749aa4050/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java#L425) will ignore the value following `-Dmvnd.rawStreams=....`. Another property `mvnd.serial` should have the same problem. > > I think that's a bug, they should be `OptionType.BOOLEAN`, shouldn't they ? For non-parameter switch `-1`, `--serial` or `--raw-streams`, the type should be `VOID`, whereas all the property should not be `VOID`. To support the merging of a property and a void cli switch, we have to assign two types to one `Environment`. I think there should be better another pr to improve these cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
