iofit commented on code in PR #56:
URL: https://github.com/apache/maven-invoker/pull/56#discussion_r1001364433
##########
src/test/java/org/apache/maven/shared/invoker/MavenCommandLineBuilderTest.java:
##########
@@ -857,46 +846,46 @@ public void testShouldInsertActivatedProfiles()
public void testMvnExecutableFromInvoker()
throws Exception
{
- assumeThat( "Test only works when maven.home is set",
- System.getProperty( "maven.home" ), is(notNullValue()));
+ assumingThat( Objects.nonNull(System.getProperty( "maven.home" )),
+ () -> System.out.println("Test only works when maven.home is
set"));
Review Comment:
I think you're right, I missed that specific part, thank you for catching
it, I've replaced assumingThat with assumeTrue which should abort/skip the test
if the condition is not met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
