gnodet commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001585461
##########
maven-model/src/test/resources/xml/pom.xml:
##########
@@ -37,12 +37,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
I'd rather have all the versions in this file set to `dummy-version` with no
filtering... see comment above.
##########
maven-model/pom.xml:
##########
@@ -37,16 +37,22 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Actually, this should be better added to dependency management of the parent
pom along with all other modules defined in the build.
##########
maven-settings/pom.xml:
##########
@@ -37,12 +37,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-settings</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-xml-impl</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
##########
maven-settings/pom.xml:
##########
@@ -37,12 +37,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-settings</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
##########
maven-model/pom.xml:
##########
@@ -37,16 +37,22 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-xml-impl</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
##########
maven-model/pom.xml:
##########
@@ -37,16 +37,22 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-xml-impl</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
</dependencies>
<build>
+ <testResources>
+ <testResource>
+ <directory>src/test/resources</directory>
+ <filtering>true</filtering>
+ </testResource>
+ </testResources>
Review Comment:
There's no real need for filtering resources here. The exact content of the
`xml/pom.xml` is really not important, the test just needs a model with a few
things in it, but the values are not used.
##########
maven-toolchain-model/pom.xml:
##########
@@ -36,12 +36,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-toolchain</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
##########
maven-toolchain-model/pom.xml:
##########
@@ -36,12 +36,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-toolchain</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-xml-impl</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
