gnodet commented on code in PR #117:
URL:
https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1001740948
##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/MojoAnnotationsScanner.java:
##########
@@ -37,13 +37,21 @@
{
String ROLE = MojoAnnotationsScanner.class.getName();
+ String V4_API_PLUGIN_PACKAGE = "org.apache.maven.api.plugin";
Review Comment:
I disagree that the fact they are not retained at runtime implies they
should be in a different jar. Should we change the retention in the new api ?
;-)
More seriously, I agree they're not used at runtime, but I think from a user
facing pov, they are the API for mojos, at the same level than the `Mojo`
interface. The fact they are interpreted at compile time and translated into an
xml is mainly an implementation detail for the average user.
I think having a monolithic jar for the API makes it way easier to just
depend on the `maven-core-api` without having to look for additional jars,
depending if you want to do simple mojos, some access to the local repository,
some custom dependency collection or whatever part which has been moved to
external components. We don't even know which ones are deprecated and which
ones should be used (for dependency collection / resolution). With a single
jar, everything coming from this jar (and it's dependencies) is part of the new
API, everything else isn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
