[ 
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625869#comment-17625869
 ] 

ASF GitHub Bot commented on MNG-7556:
-------------------------------------

michael-o commented on code in PR #810:
URL: https://github.com/apache/maven/pull/810#discussion_r1008393624


##########
api/maven-api-model/src/main/mdo/maven.mdo:
##########
@@ -2672,7 +2672,7 @@
         <field>
           <name>property</name>
           <version>4.0.0+</version>
-          <description>Specifies that this profile will be activated when this 
system property is
+          <description>Specifies that this profile will be activated when this 
property is
             specified.</description>

Review Comment:
   I checked `PropertyProfileActivator`. It DOES use user and then system 
properties. No project/model properties, *but* the passed 
`ProfileActivationContext` contains a `getProjectProperties()` method so we 
could make this happen.





> Clean up notion between user properties and system properties
> -------------------------------------------------------------
>
>                 Key: MNG-7556
>                 URL: https://issues.apache.org/jira/browse/MNG-7556
>             Project: Maven
>          Issue Type: Task
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.9.0-candidate, 4.0.0, 4.0.0-alpha-3
>
>
> For a very long time we have documented that the user can set system 
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties 
> which are promoted to system properties and it some cases system properties 
> cannot be modified *after* the JVM has been started. To properly set system 
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a 
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to