[ 
https://issues.apache.org/jira/browse/MNG-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626183#comment-17626183
 ] 

ASF GitHub Bot commented on MNG-7588:
-------------------------------------

kwin commented on code in PR #862:
URL: https://github.com/apache/maven/pull/862#discussion_r1008809496


##########
maven-plugin-api/pom.xml:
##########
@@ -112,6 +117,53 @@ under the License.
               </params>
             </configuration>
           </execution>
+          <execution>
+            <id>velocity-plugin</id>
+            <phase>generate-sources</phase>
+            <goals>
+              <goal>velocity</goal>
+            </goals>
+            <configuration>
+              <version>1.1.0</version>
+              <models>
+                <model>src/main/mdo/plugin.mdo</model>
+              </models>
+              <templates>
+                <template>src/main/mdo/model.vm</template>
+                <template>src/main/mdo/reader.vm</template>

Review Comment:
   should we generate a writer here or rather separately in m-plugin-tools?





> Plugin Descriptor: Java Beans and Reader should be generated automatically
> --------------------------------------------------------------------------
>
>                 Key: MNG-7588
>                 URL: https://issues.apache.org/jira/browse/MNG-7588
>             Project: Maven
>          Issue Type: Improvement
>          Components: Plugin API
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>              Labels: plugin-descriptor-1.1
>
> Currently the code in {{o.a.m.plugin.descriptor}} is generated manually. That 
> requires additional maintenance effort and has the risk that the underlying 
> model and the classes are out of sync. Both Java beans and readers should be 
> generated automatically from the underlying model.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to