HannesWell commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012086763
########## src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml: ########## @@ -0,0 +1,68 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<lifecycleMappingMetadata> Review Comment: > Imagine if every IDE ask for storing their specific files? sounds a bad design to me. Indeed that would be bad and was the reason why I/we the M2E team reached out to the Maven devs on their mailing list (the link @kwin posted above) to establish a unified API defined/maintained by Maven that all IDEs could use. Eventually this probably would have lead to a similar Maven-defined/maintained lifecycle-mapping metadata format (which actually also could be generated from annotations see e.g. https://github.com/eclipse-m2e/m2e-core/issues/830). But there was only negative feedback from all Maven devs about that suggestion, so each IDE has to continue to handle it their one way. Anyway, as @mickaelistria said below we can maintain that metadata in a Eclipse M2E plug-in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
