AlexanderAshitkin commented on code in PR #36:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/36#discussion_r1014326181


##########
src/test/java/org/apache/maven/buildcache/its/junit/IntegrationTestExtension.java:
##########
@@ -208,6 +208,8 @@ public Object resolveParameter( ParameterContext 
parameterContext,
 
             Verifier verifier = new Verifier( testExecutionDir.toString(), 
true );
             verifier.setLogFileName( "../log.txt" );
+            verifier.setSystemProperty( "projectVersion", System.getProperty( 
"projectVersion" ) );
+            verifier.setLocalRepo( System.getProperty( "localRepo" ) );

Review Comment:
   Please notice I also faced a similar problem [while adding 
tests](src/test/java/org/apache/maven/buildcache/its/ForkedExecutionsTest.java).
 But I decided to use per-run temp directory to have clean state between runs 
(at least for cache). 
   
   So here are the questions:
   1. how this repository is cleaned?
   2. Will it be unique between tests? Each integration test assumes clean state
   3. On local workstation - will it be also clean each time? Tests to be run 
on local machine as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to