[
https://issues.apache.org/jira/browse/MNG-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629484#comment-17629484
]
ASF GitHub Bot commented on MNG-7590:
-------------------------------------
michael-o commented on code in PR #863:
URL: https://github.com/apache/maven/pull/863#discussion_r1014831807
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -150,6 +152,8 @@ public DefaultRepositorySystemSession newRepositorySession(
MavenExecutionReques
configProps.put( ConfigurationProperties.USER_AGENT, getUserAgent() );
configProps.put( ConfigurationProperties.INTERACTIVE,
request.isInteractiveMode() );
configProps.put( "maven.startTime", request.getStartTime() );
+ // First add properties populated from settings.xml
+ configProps.putAll( getConfigFromRequestProfiles( request ) );
// Resolver's ConfigUtils solely rely on config properties, that is
why we need to add both here as well.
Review Comment:
I think this order also complies with preferred inheritance at point 7:
https://cwiki.apache.org/confluence/display/MAVEN/Commandline+inheritance
> Allow configure resolver by properties in settings.xml
> ------------------------------------------------------
>
> Key: MNG-7590
> URL: https://issues.apache.org/jira/browse/MNG-7590
> Project: Maven
> Issue Type: Improvement
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
>
> New Artifact Resolver has many useful configuration options, currently we
> only have the option to pass them as system or user properties.
> It will be useful to have possibility to provide them by properties in
> settings.xml to have whole configuration in one place.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
