[
https://issues.apache.org/jira/browse/MNG-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634461#comment-17634461
]
ASF GitHub Bot commented on MNG-7597:
-------------------------------------
slawekjaranowski commented on code in PR #872:
URL: https://github.com/apache/maven/pull/872#discussion_r1023091087
##########
maven-core/src/main/java/org/apache/maven/internal/impl/PropertiesAsMap.java:
##########
@@ -71,6 +71,8 @@ public Entry<String, String> next()
{
throw new NoSuchElementException();
}
+ Entry<Object, Object> next = this.next;
Review Comment:
please use another name for local variable ... it is not clear which `next`
is used
##########
maven-core/src/test/java/org/apache/maven/internal/impl/PropertiesAsMapTest.java:
##########
@@ -0,0 +1,38 @@
+package org.apache.maven.internal.impl;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+
+import org.junit.jupiter.api.Test;
+
+public class PropertiesAsMapTest
+{
+
+ @Test
+ public void testPropertiesAsMap()
+ {
+ Properties props = new Properties();
+ props.setProperty( "foo", "bar" );
+ Map<String, String> map = new HashMap<>( new PropertiesAsMap( props )
);
Review Comment:
please add assertions.
maybe also test for confirm, that PropertiesAsMap contains only has String
as key and values
> Infinite loop in PropertiesAsMap
> --------------------------------
>
> Key: MNG-7597
> URL: https://issues.apache.org/jira/browse/MNG-7597
> Project: Maven
> Issue Type: Bug
> Affects Versions: 4.0.0-alpha-2
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
