michael-o commented on code in PR #878:
URL: https://github.com/apache/maven/pull/878#discussion_r1027108363


##########
apache-maven/src/assembly/shared/mvnvalidate.ps1:
##########
@@ -0,0 +1,9 @@
+# check mvn home
+if (-not $env:MAVEN_HOME) {
+    $env:MAVEN_HOME = (Get-Item $PSScriptRoot"\..")
+}

Review Comment:
   This is wrong. `MAVEN_HOME` is neither an environment variable, nor can it 
be passed externally. It is solely private. See 
https://github.com/apache/maven/blob/29283a10596c92a9283d789d4c661dd242cec916/apache-maven/src/assembly/shared/mvnvalidate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to