[
https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640663#comment-17640663
]
Gary D. Gregory commented on MNG-7316:
--------------------------------------
>From a functional level, I only care that our Commons plugin works and let's
>us simplify our release process. The details are not important to me at least;
>yes, the current implementation is hacky-nasty but that's what we had to do to
>adapt to changes in Maven.
I think [~chtompki] wrote that part of the plugin and I hacked on top of it to
adapt to the Maven change, but, again, I am happy that it works, and I am also
ok if it gets rewritten, as long as it all works the same from the command line.
I don't know what the best path forward is, but for now, I think the hack will
stay in place on our end until either it breaks or there is an official API to
do what we need. From my POV, any Maven public or protected API is fair game
and therefore "official" unless it is clearly documented not to be or is in a
package with an obvious name like "internal".
What should we do?
> MavenProject.getAttachedArtifacts() regression with 3.8.1
> ---------------------------------------------------------
>
> Key: MNG-7316
> URL: https://issues.apache.org/jira/browse/MNG-7316
> Project: Maven
> Issue Type: Bug
> Components: Core
> Affects Versions: 3.8.2, 3.8.3
> Reporter: Gary D. Gregory
> Assignee: Michael Osipov
> Priority: Critical
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> The method {{MavenProject.getAttachedArtifacts()}} as of 3.8.2 breaks
> releasing components for us at Apache Commons using our Maven Release plugin
> because the list returned is now immutable, we now get an exception when
> calling {{remove()}} on the collection returned by the API; see
> [https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137]
> This worked fine in 3.8.1, may you please change it back for 3.8.4?
> We cannot use Maven 3.8.2 and 3.8.3 to release our components.
> ([~michael-o]: Ironically, I discovered this trying to create a release
> candidate for Apache Commons CLI.)
> The exception in 3.8.3:
> {quote}Caused by: java.lang.UnsupportedOperationException
> at java.util.Collections$UnmodifiableCollection.remove
> (Collections.java:1060)
> at
> org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute
> (CommonsDistributionDetachmentMojo.java:136)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
