gnodet commented on code in PR #183:
URL:
https://github.com/apache/maven-plugin-tools/pull/183#discussion_r1036396906
##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java:
##########
@@ -448,14 +448,15 @@ private String getRequiredJavaVersion( PluginToolsRequest
request )
{
return requiredJavaVersion;
}
- String requiredJavaVersion = request.getRequiredJavaVersion();
- if ( requiredJavaVersion == null )
+ String minRequiredJavaVersion = request.getRequiredJavaVersion();
+ if ( minRequiredJavaVersion == null )
Review Comment:
Can the version given in the request be a range ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
