[
https://issues.apache.org/jira/browse/MPLUGIN-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641544#comment-17641544
]
ASF GitHub Bot commented on MPLUGIN-425:
----------------------------------------
gnodet commented on code in PR #183:
URL:
https://github.com/apache/maven-plugin-tools/pull/183#discussion_r1036396906
##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java:
##########
@@ -448,14 +448,15 @@ private String getRequiredJavaVersion( PluginToolsRequest
request )
{
return requiredJavaVersion;
}
- String requiredJavaVersion = request.getRequiredJavaVersion();
- if ( requiredJavaVersion == null )
+ String minRequiredJavaVersion = request.getRequiredJavaVersion();
+ if ( minRequiredJavaVersion == null )
Review Comment:
Can the version given in the request be a range ?
> Plugin descriptor should contain the requiredJavaVersion/requiredMavenVersion
> -----------------------------------------------------------------------------
>
> Key: MPLUGIN-425
> URL: https://issues.apache.org/jira/browse/MPLUGIN-425
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: next-release
>
>
> As plugin descriptor schema v 1.1.0 supports requiring a Java version
> (support added in MNG-7566) and Maven version (support added in MNG-7570),
> the descriptor goal provide a dedicated mojo parameter to set these elements.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
